add quit channel to clean up after self

network/network.go

@@ -56,89 +56,98 @@ func ConnectToServer() (net.Conn, int32, error) {
 	return conn, playerID, nil
 }
 
-func HandleServerCommunication(conn net.Conn, playerID int32, player *types.Player, otherPlayers map[int32]*types.Player) {
-	// Create a buffered reader for the connection
+func HandleServerCommunication(conn net.Conn, playerID int32, player *types.Player, otherPlayers map[int32]*types.Player, quitChan <-chan struct{}) {
 	reader := bufio.NewReader(conn)
 
 	actionTicker := time.NewTicker(types.ClientTickRate)
 	defer actionTicker.Stop()
 
 	go func() {
-		for range actionTicker.C {
-			player.Lock()
-			if len(player.ActionQueue) > 0 {
-				actions := make([]*pb.Action, len(player.ActionQueue))
-				copy(actions, player.ActionQueue)
+		for {
+			select {
+			case <-quitChan:
+				return
+			case <-actionTicker.C:
+				player.Lock()
+				if len(player.ActionQueue) > 0 {
+					actions := make([]*pb.Action, len(player.ActionQueue))
+					copy(actions, player.ActionQueue)
 
-				batch := &pb.ActionBatch{
-					PlayerId: playerID,
-					Actions:  actions,
-					Tick:     player.CurrentTick,
+					batch := &pb.ActionBatch{
+						PlayerId: playerID,
+						Actions:  actions,
+						Tick:     player.CurrentTick,
+					}
+
+					player.ActionQueue = player.ActionQueue[:0]
+					player.Unlock()
+
+					if err := writeMessage(conn, batch); err != nil {
+						log.Printf("Failed to send actions to server: %v", err)
+						return
+					}
+				} else {
+					player.Unlock()
 				}
-
-				player.ActionQueue = player.ActionQueue[:0]
-				player.Unlock()
-
-				if err := writeMessage(conn, batch); err != nil {
-					log.Printf("Failed to send actions to server: %v", err)
-					return
-				}
-			} else {
-				player.Unlock()
 			}
 		}
 	}()
 
 	for {
-		// Read message length (4 bytes)
-		lengthBuf := make([]byte, 4)
-		if _, err := io.ReadFull(reader, lengthBuf); err != nil {
-			log.Printf("Failed to read message length: %v", err)
+		select {
+		case <-quitChan:
 			return
-		}
-		messageLength := binary.BigEndian.Uint32(lengthBuf)
-
-		// Read the full message
-		messageBuf := make([]byte, messageLength)
-		if _, err := io.ReadFull(reader, messageBuf); err != nil {
-			log.Printf("Failed to read message body: %v", err)
-			return
-		}
-
-		var serverMessage pb.ServerMessage
-		if err := proto.Unmarshal(messageBuf, &serverMessage); err != nil {
-			log.Printf("Failed to unmarshal server message: %v", err)
-			continue
-		}
-
-		player.Lock()
-		player.CurrentTick = serverMessage.CurrentTick
-
-		tickDiff := serverMessage.CurrentTick - player.CurrentTick
-		if tickDiff > types.MaxTickDesync {
-			for _, state := range serverMessage.Players {
-				if state.PlayerId == playerID {
-					player.ForceResync(state)
-					break
-				}
+		default:
+			// Read message length (4 bytes)
+			lengthBuf := make([]byte, 4)
+			if _, err := io.ReadFull(reader, lengthBuf); err != nil {
+				log.Printf("Failed to read message length: %v", err)
+				return
 			}
-		}
-		player.Unlock()
+			messageLength := binary.BigEndian.Uint32(lengthBuf)
 
-		for _, state := range serverMessage.Players {
-			if state.PlayerId == playerID {
+			// Read the full message
+			messageBuf := make([]byte, messageLength)
+			if _, err := io.ReadFull(reader, messageBuf); err != nil {
+				log.Printf("Failed to read message body: %v", err)
+				return
+			}
+
+			var serverMessage pb.ServerMessage
+			if err := proto.Unmarshal(messageBuf, &serverMessage); err != nil {
+				log.Printf("Failed to unmarshal server message: %v", err)
 				continue
 			}
 
-			if otherPlayer, exists := otherPlayers[state.PlayerId]; exists {
-				otherPlayer.UpdatePosition(state, types.ServerTickRate)
-			} else {
-				otherPlayers[state.PlayerId] = types.NewPlayer(state)
-			}
-		}
+			player.Lock()
+			player.CurrentTick = serverMessage.CurrentTick
 
-		if g, ok := player.UserData.(*game.Game); ok && len(serverMessage.ChatMessages) > 0 {
-			g.Chat.HandleServerMessages(serverMessage.ChatMessages)
+			tickDiff := serverMessage.CurrentTick - player.CurrentTick
+			if tickDiff > types.MaxTickDesync {
+				for _, state := range serverMessage.Players {
+					if state.PlayerId == playerID {
+						player.ForceResync(state)
+						break
+					}
+				}
+			}
+			player.Unlock()
+
+			for _, state := range serverMessage.Players {
+				if state.PlayerId == playerID {
+					continue
+				}
+
+				if otherPlayer, exists := otherPlayers[state.PlayerId]; exists {
+					otherPlayer.UpdatePosition(state, types.ServerTickRate)
+				} else {
+					otherPlayers[state.PlayerId] = types.NewPlayer(state)
+				}
+			}
+
+			if g, ok := player.UserData.(*game.Game); ok && len(serverMessage.ChatMessages) > 0 {
+				g.Chat.HandleServerMessages(serverMessage.ChatMessages)
+			}
 		}
 	}
 }